Skip to content

Deactivate maxRecDepth check during term elaboration #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: eq-arith-simp-rules
Choose a base branch
from
Open

Deactivate maxRecDepth check during term elaboration #36

wants to merge 1 commit into from

Conversation

@etiennejf
Copy link
Collaborator

@etiennejf etiennejf commented Nov 22, 2025 •
edited
Loading

Deactivate maxRecDepth check during term elaboration

Description

This small PR covers #40 by properly setting maxRecDepth and maxHeartbeats to zero before term elaboration is invoked in the #solve command.

Checklist

  • All theorems valid for each formalization in CI
  • All the specified lean file are properly considered when compiling and verifying the formalization
  • Self review of the code has been done.
  • Reviewer has been requested.
  • Reviewer has performed the following tasks
    • Ensure that all the test cases are still valid
    • Ensure that each specified lean file is properly considered in the tool chain.

@etiennejf etiennejf self-assigned this Nov 22, 2025
RSoulatIOHK
RSoulatIOHK requested changes Nov 25, 2025
View reviewed changes
Copy link
Collaborator

@RSoulatIOHK RSoulatIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the issue that made you change this?

@RSoulatIOHK RSoulatIOHK self-requested a review November 27, 2025 12:55
RSoulatIOHK
RSoulatIOHK approved these changes Nov 27, 2025
View reviewed changes
Copy link
Collaborator

@RSoulatIOHK RSoulatIOHK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it's supposed to do. Sad we have to do that though now. Maybe we can revisit in the future when new versionf of Lean 4 are released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RSoulatIOHK RSoulatIOHK RSoulatIOHK approved these changes

Assignees

@etiennejf etiennejf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@etiennejf @RSoulatIOHK